Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better info on compiler crashes #15890

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Aug 20, 2022

When encountering a compiler crash, show the current phase and the currently compiled unit.

When encountering a compiler crash, show the current phase and the currently compiled unit.
@odersky
Copy link
Contributor Author

odersky commented Aug 20, 2022

This should help to make progress on #15845.

Copy link
Member

@KacperFKorban KacperFKorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some other phases that override runOn and don't call super.runOn. Should we add this info to them as well?
Those are: ReadTasty, Parser, init.Checker.

@odersky
Copy link
Contributor Author

odersky commented Aug 20, 2022

We could, but we are really mostly interested in Typer. Crashes elsewhere are much easier to pintpoint.

@KacperFKorban KacperFKorban merged commit ead0fbc into scala:main Aug 20, 2022
@KacperFKorban KacperFKorban deleted the add-phase-info branch August 20, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants